Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workflows): Add missing typescript packages #3385

Merged
merged 6 commits into from
Aug 7, 2023
Merged

Conversation

rogerthatdev
Copy link
Contributor

This PR will update the workflows quickstart sample:

  • move the ts-node package from devDependencies to dependencies in package.json
  • add typescript as a dependency in package.json

These changes will allow the execution of the typescript sample via npx ts-node index.ts <PROJECT_ID> us-central1 myFirstWorkflow

Documentation page will be updated to reflect this

@rogerthatdev rogerthatdev requested review from a team as code owners August 5, 2023 00:37
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Aug 5, 2023

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added api: workflows Issues related to the Workflows API. samples Issues that are directly related to samples. labels Aug 5, 2023
@kweinmeister kweinmeister enabled auto-merge (squash) August 7, 2023 15:07
@kweinmeister kweinmeister merged commit 631541c into main Aug 7, 2023
14 checks passed
@kweinmeister kweinmeister deleted the fix-ts-workflows branch August 7, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions:force-run api: workflows Issues related to the Workflows API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants